[PATCH] D95619: [AMDGPU] Add more PAL metadata register names

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 24 09:12:55 PST 2021


foad added a comment.

In D95619#2585055 <https://reviews.llvm.org/D95619#2585055>, @kzhuravl wrote:

> I am not familiar with graphics side much, but is there any reason to not use COMPUTE_PGM_RSRC* registers from https://github.com/llvm/llvm-project/blob/main/llvm/include/llvm/Support/AMDHSAKernelDescriptor.h#L130 ?

For dumping PAL metadata all we want is the offsets of the registers. AMDHSAKernelDescriptor.h seems to define the fields within some of these registers instead. Obviously it's related, but I don't think there's actually any duplicated information there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95619/new/

https://reviews.llvm.org/D95619



More information about the llvm-commits mailing list