[PATCH] D96258: [AMDGPU] Introduce Strict WQM mode

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 24 06:12:23 PST 2021


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIPreAllocateWWMRegs.cpp:180
+
+  dbgs() << "region: " << MI << "\n";
+}
----------------
Printing MI already includes the newline


================
Comment at: llvm/lib/Target/AMDGPU/SIWholeQuadMode.cpp:109
 
+  std::pair<char, std::string> Mapping[] = {
+      std::make_pair(StateWQM, "WQM"),
----------------
static const, const char*?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96258/new/

https://reviews.llvm.org/D96258



More information about the llvm-commits mailing list