[PATCH] D97046: [lit] Add "late_tests" test suite config option

[David Zarzycki via Phabricator via llvm-commits]

davezarzycki added inline comments.


================
Comment at: llvm/utils/lit/lit/TestingConfig.py:130-133
         # List of tests to run early.
         self.early_tests = {}
+        # Regular expression for tests to run late.
+        self.late_tests = "^$"
----------------
jhenderson wrote:
> Why are late tests a regular expression, but early tests a list? The inconsistency seems confusing to me.
"late_tests" does not need to be regular expression. It was just expedient given my goals. The "late_tests" variable could be a list if directories if we treat tests therein as being "late".


================
Comment at: llvm/utils/lit/tests/late-tests.py:1
+## Check that we can run tests early.
+
----------------
jhenderson wrote:
> You probably also want a test case showing the interaction between early and late tests (i.e. if both are set what happens, both in the case where they impact different sets, and where one test is specified in both).
Sure. Once we settle on the regex question, I can make this change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97046/new/

https://reviews.llvm.org/D97046