[PATCH] D90479: [ValueTracking] ComputeKnownBits - minimum leading/trailing zero bits in LSHR/SHL (PR44526)

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/lib/Support/KnownBits.cpp:207
+    }
+  }
+
----------------
nikic wrote:
> Hm, this code basically repeats what ValueTracking does in a slightly weaker form (using all shifts between min and max, rather than only the possible ones). If we're going to do this inside the KnownBits function itself, then I think we should be doing it only here, not in both places.
I'm intending to clean this up as a followup - cheers


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90479/new/

https://reviews.llvm.org/D90479