[PATCH] D97192: [RISCV] Unify scalable- and fixed-vector EXTRACT_SUBVECTOR lowering
Fraser Cormack via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 24 03:44:55 PST 2021
frasercrmck marked an inline comment as done.
frasercrmck added inline comments.
================
Comment at: llvm/test/CodeGen/RISCV/rvv/fixed-vectors-extract-subvector.ll:27
+; CHECK-NEXT: vle8.v v25, (a0)
+; CHECK-NEXT: vslidedown.vi v25, v25, 6
+; CHECK-NEXT: addi a0, zero, 2
----------------
craig.topper wrote:
> Based on a conversation with Andrew Waterman I had yesterday, the VL for the slidedown should just cover the elements we care about. Especially when the input LMUL > 1 and the output is LMUL <= 1. The smaller VL would allow the computation for the upper registers to be skipped. It still could be beneficial on CPUs with ALUs narrower than the VLEN.
Ah that's interesting, thanks. I've updated the VL for the fixed-length lowering accordingly.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97192/new/
https://reviews.llvm.org/D97192
More information about the llvm-commits
mailing list