[PATCH] D97301: [RISCV] Support fixed-length vector FP_ROUND & FP_EXTEND

Fraser Cormack via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 24 03:15:14 PST 2021


frasercrmck added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.h:181
+  // FP_ROUND_VL carries the extra TRUNC operand before the Mask/VL to maintain
+  // parity with the regular ISD node.
+  FP_ROUND_VL,
----------------
craig.topper wrote:
> I doubt we need that TRUNC operand. I think its use in the regular node is for scalar call arguments.
Fair enough. I was trying to match the standard node in case we ever wanted to use the same logic to process the two together without having to conditionally change operand indices. I'll get rid of it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97301/new/

https://reviews.llvm.org/D97301



More information about the llvm-commits mailing list