[PATCH] D97236: [MC][ARM] add .w suffixes for BL (T1) and DBG

David Spickett via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 24 03:11:41 PST 2021


DavidSpickett added a comment.

LGTM with nits fixed.



================
Comment at: llvm/test/MC/ARM/basic-thumb2-instructions.s:659
+@ CHECK: it	ne                      @ encoding: [0x18,0xbf]
+@ CHECK: dbgne	#0                      @ encoding: [0xaf,0xf3,0xf0,0x80]
 
----------------
nit: indent the @ encoding


================
Comment at: llvm/test/MC/ARM/thumb2-branches.s:105
+@ CHECK: it	ne                      @ encoding: [0x18,0xbf]
+@ CHECK: blne	#256                    @ encoding: [0x00,0xf0,0x80,0xf8]
 @ CHECK: bmi.w	#-256                   @ encoding: [0x3f,0xf5,0x80,0xaf]
----------------
nit: indent the @ encoding


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97236/new/

https://reviews.llvm.org/D97236



More information about the llvm-commits mailing list