[PATCH] D97339: [lli] Add JITLink in-process debugging support

[Stefan Gränitz via Phabricator via llvm-commits]

sgraenitz added a comment.

In D97339#2584160 <https://reviews.llvm.org/D97339#2584160>, @lhames wrote:

>> This patch adds a --dyld flag
>
> Could this be changed to `-jit-linker`? It's verbose, but I think `-dyld` is too likely to cause confusion

I don't really like the duplication in `-jit-linker=jitlink`, but well it's acceptable.

> We could create an entirely new library for this, but that feels like overkill. I think OrcTargetProcess seems reasonable. I think that the new dependence diagram would look like:
>
>   ORC -> { JITLink, OrcShared }
>   OrcTargetProcess -> { OrcShared }
>   ExecutionEngine -> { RuntimeDyld, OrcTargetProcess }

Yes, OrcTargetProcess is so small that the overhead in ExecutionEngine will hardly be noticeable.
So let's keep it like that, including the FIXME. I guess we can move the symbol definitions from OrcTargetProcess the the Orc runtime one day.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97339/new/

https://reviews.llvm.org/D97339