[llvm] d637235 - [JITLink] Fix comments about JITLink's generic link algorithm.

[Lang Hames via llvm-commits]

Author: Lang Hames
Date: 2021-02-24T21:02:37+11:00
New Revision: d637235ceed7517287c8b4a724ef58a4681b8ed3

URL: https://github.com/llvm/llvm-project/commit/d637235ceed7517287c8b4a724ef58a4681b8ed3
DIFF: https://github.com/llvm/llvm-project/commit/d637235ceed7517287c8b4a724ef58a4681b8ed3.diff

LOG: [JITLink] Fix comments about JITLink's generic link algorithm.

These comments had gotten out of date with the code.

Added: 
    

Modified: 
    llvm/lib/ExecutionEngine/JITLink/JITLinkGeneric.h

Removed: 
    


################################################################################
diff  --git a/llvm/lib/ExecutionEngine/JITLink/JITLinkGeneric.h b/llvm/lib/ExecutionEngine/JITLink/JITLinkGeneric.h
index 1d28f5006b2b..8d551099c389 100644
--- a/llvm/lib/ExecutionEngine/JITLink/JITLinkGeneric.h
+++ b/llvm/lib/ExecutionEngine/JITLink/JITLinkGeneric.h
@@ -56,15 +56,18 @@ class JITLinkerBase {
   //   1.2: Prune graph
   //   1.3: Run post-prune passes
   //   1.4: Sort blocks into segments
-  //   1.5: Allocate segment memory
-  //   1.6: Identify externals and make an async call to resolve function
+  //   1.5: Allocate segment memory, update node vmaddrs to target vmaddrs
+  //   1.6: Run post-allocation passes
+  //   1.7: Notify context of final assigned symbol addresses
+  //   1.8: Identify external symbols and make an async call to resolve
   void linkPhase1(std::unique_ptr<JITLinkerBase> Self);
 
   // Phase 2:
   //   2.1: Apply resolution results
-  //   2.2: Fix up block contents
-  //   2.3: Call OnResolved callback
-  //   2.3: Make an async call to transfer and finalize memory.
+  //   2.2: Run pre-fixup passes
+  //   2.3: Fix up block contents
+  //   2.4: Run post-fixup passes
+  //   2.5: Make an async call to transfer and finalize memory.
   void linkPhase2(std::unique_ptr<JITLinkerBase> Self,
                   Expected<AsyncLookupResult> LookupResult,
                   SegmentLayoutMap Layout);