[PATCH] D97110: [InstrProfiling] Use nobits as __llvm_prf_cnts section type in ELF
Petr Hosek via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 24 00:48:22 PST 2021
phosek reopened this revision.
phosek added a comment.
This revision is now accepted and ready to land.
The problem seems to be that Global Value Optimizer may evaluate and eliminate global initializer, and propagate the value to the counter symbol which is no longer zero initialized in that case. This is working as intended. Given that, we may have to change the logic to first ensure that the section content is all zeros before choosing the `nobits` type. I have reverted this change for now while I work on the implementation.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97110/new/
https://reviews.llvm.org/D97110
More information about the llvm-commits
mailing list