[PATCH] D96698: RFC: [LLD] [COFF] Include VirtualSize when sizing sections

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo abandoned this revision.
mstorsjo added a comment.

In D96698#2583410 <https://reviews.llvm.org/D96698#2583410>, @rnk wrote:

> Is it possible to create objects with bss sections like this when enabling -fcommon? I vaguely recall running into a few cases where common linkage mattered in chrome.

No, commons are handled entirely differently.

In D96698#2583428 <https://reviews.llvm.org/D96698#2583428>, @rnk wrote:

> I played around a bit, but I wasn't able to get LLVM to make anything like the object described. I think I would prefer not to put this conditional in the hot path if we agree that tools shouldn't produce objects like this.

Yeah I'd tend to agree at this point. From the outset of the bug report, it seemed like a potentially valid case (as there's two size fields one could use for conveying the size in the case of bss sections where there's no actual data in the object file anyway), but given that the fix is highly generic and essentially could affect handling of all object files' sections, I think we'd rather not do it. The issue has been fixed on the Go side now anyways.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96698/new/

https://reviews.llvm.org/D96698