[PATCH] D97353: [Coverage][Unittest] Fix stringref issue

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 23 22:44:43 PST 2021


phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.

LGTM, thanks a lot for looking into this!



================
Comment at: llvm/unittests/ProfileData/CoverageMappingTest.cpp:204-205
                            OutputFunctionCoverageData &Data) {
+    Filenames.clear(); // We will re-use the StringRef in duplicate tests, clear
+                       // it to avoid clobber previous ones.
     Filenames.resize(Files.size() + 1);
----------------
Would it be possible to move the comment on the line above?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97353/new/

https://reviews.llvm.org/D97353



More information about the llvm-commits mailing list