[PATCH] D97240: [AArch64][GlobalISel] Fix manual selection for v4s16 and v8s8 G_DUP

[Amara Emerson via Phabricator via llvm-commits]

aemerson accepted this revision.
aemerson added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64InstructionSelector.cpp:3209
+        return false;
+    } else if (SrcTy.getSizeInBits() == 8) {
+      if (NumElts == 16)
----------------
I think it's probably more readable if you just do a sequence of checks using LLT comparisons. I.e.
```if (SrcTy == LLT::vector(8, 16))
   ....
else if (SrcTy == LLT::vector(4, 16))
   ....
etc
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97240/new/

https://reviews.llvm.org/D97240