[PATCH] D96928: [LICM][Coroutine] Don't sink stores from loops with coro.suspend instructions

Xun Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 23 21:56:54 PST 2021


lxfind added a comment.

In D96928#2583784 <https://reviews.llvm.org/D96928#2583784>, @junparser wrote:

>> Perhaps we need to introduce a new IR instruction for suspend instead of relying on intrinsics, but that's not going to be something we can redesign in a short amount of time.
>
> How about add fence instruction between coro.suspend and ret block?

Can you elaborate using the test case from this patch? 
The problem is at the edge from the switch to the block. There doesn't seem a way to prevent from sending instructions over an edge.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96928/new/

https://reviews.llvm.org/D96928



More information about the llvm-commits mailing list