[PATCH] D97350: [SampleFDO] Another fix to prevent repeated indirect call promotion in sample loader pass

Wei Mi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 23 20:53:14 PST 2021


wmi added a comment.

In D97350#2583817 <https://reviews.llvm.org/D97350#2583817>, @davidxl wrote:

> The logic seems complicated. Is it better to use (uint64)-1 as the special value to mark promoted candidates?
> ( I posted this comment on the wrong thread).

That is a very good suggestion and should simplify selectCallTargets a lot. Will try it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97350/new/

https://reviews.llvm.org/D97350



More information about the llvm-commits mailing list