[PATCH] D96109: Refactor implementation of -funique-internal-linkage-names.

Sriraman Tallam via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 23 19:19:15 PST 2021


tmsriram added a comment.

In D96109#2583589 <https://reviews.llvm.org/D96109#2583589>, @dblaikie wrote:

> Looks good to me - maybe give it a week or so in case other reviewers have some unresolved concerns.

Thanks! Regarding double-underscore for prefixes, there is also "__part" which is used by function parts created via basic block sections. I dont have a strong opinion on the usage of "__" and I can reopen the discussion if needed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96109/new/

https://reviews.llvm.org/D96109



More information about the llvm-commits mailing list