[PATCH] D96109: Refactor implementation of -funique-internal-linkage-names.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

> D8243 <https://reviews.llvm.org/D8243>

Did you link to the wrong revision?



================
Comment at: clang/test/CodeGen/unique-internal-linkage-names-dwarf.cpp:4
+//
+// RUN: %clang_cc1 -triple x86_64-unknown-linux -debug-info-kind=limited -dwarf-version=4 -emit-llvm -o -  %s | FileCheck %s --check-prefix=PLAIN
+// RUN: %clang_cc1 -triple x86_64-unknown-linux -debug-info-kind=limited -dwarf-version=4 -funique-internal-linkage-names -emit-llvm -o -  %s | FileCheck %s --check-prefix=UNIQUE
----------------
excess spaces after `-o -`


================
Comment at: clang/test/CodeGen/unique-internal-linkage-names.cpp:62
+// UNIQUE: define internal i32 @_ZL4mverv.__uniq.{{[0-9]+}}.sse4.2
+// UNIQUE: "sample-profile-suffix-elision-policy"
----------------
If you want to test a function attribute

```
// UNIQUE: ... @function() [[#ATTR:]]
// UNIQUE: attributes [[#ATTR]] = {{{.*}}"sample-profile...}}
```

The current test does not test which definition this attribute is attached to.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96109/new/

https://reviews.llvm.org/D96109