[PATCH] D97264: [RISCV] Define types for Zvlsseg.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: clang/include/clang/AST/ASTContext.h:1024
+#define RVV_TUPLE(Name, ElemId, Id, SingletonId, NE, EB, NF, IsSigned, IsFP) \
+  QualType SingletonId;
 #include "clang/Basic/RISCVVTypes.def"
----------------
craig.topper wrote:
> Why is this QualType and not CanQualType? I don't know what the difference is myself.
Is there any downside to adding all these members to the ASTContext? I suspect the builtin types have grown quite a bit since this was initially set up. @rjmccall or @rsmith is this something we need to be concerned about?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97264/new/

https://reviews.llvm.org/D97264