[PATCH] D97268: [X86] Use correct padding when in 16-bit mode

Bill Wendling via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 23 15:38:36 PST 2021


void added a comment.

In D97268#2583270 <https://reviews.llvm.org/D97268#2583270>, @jyknight wrote:

> In D97268#2582826 <https://reviews.llvm.org/D97268#2582826>, @void wrote:
>
>> In D97268#2581555 <https://reviews.llvm.org/D97268#2581555>, @jyknight wrote:
>>
>>> This change also modifies (breaks!) the 32-bit NOP set, definitely shouldn't do that. (But I think all that can be reverted, in any case).
>>
>> Which part did it break?
>
> It replaced the single-instruction NOPs with new sequences consisting of multiple instructions.

That...shouldn't matter since a NOP is a NOP. Regardless, I removed that modification to simplify the patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97268/new/

https://reviews.llvm.org/D97268



More information about the llvm-commits mailing list