[PATCH] D97335: [Orc] Add JITLink debug support plugin for ELF x86-64

[Stefan Gränitz via Phabricator via llvm-commits]

sgraenitz added inline comments.


================
Comment at: llvm/lib/ExecutionEngine/JITLink/DebugSupport.cpp:60
+    // TODO: Could we use the given buffer as working memory directly
+    // and avoid the unnecessary copy below?
+    Expected<std::unique_ptr<Allocation>> AllocOrErr =
----------------
Is it possible to set an allocation's working memory to an existing buffer? Is it worth adding?


================
Comment at: llvm/lib/ExecutionEngine/Orc/DebugObjectManagerPlugin.cpp:34
+
+  // We should never have more than one pending debug object.
+  ResourceKey Key = getResourceKey(MR);
----------------
This still holds. Can we have more than one resource per MR?


================
Comment at: llvm/lib/ExecutionEngine/Orc/TargetProcess/JITLoaderGDB.cpp:64
+}
+}
+
----------------
This replicates the code for the GDB JIT interface definition fom ExecutionEngine and causes the duplication in D97339 eventually. Is there a way to shared it without creating a dedicated library? If there's a better way, I am eager to learn about it.

Otherwise, maybe one more reason to look at this https://reviews.llvm.org/D95747#2532432 ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97335/new/

https://reviews.llvm.org/D97335