[PATCH] D97247: [WebAssembly] Fix incorrect grouping and sorting of exceptions
Heejin Ahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 23 14:53:58 PST 2021
aheejin added a comment.
In D97247#2583234 <https://reviews.llvm.org/D97247#2583234>, @tlively wrote:
> +1 This is an impressively thorough and deep explanation of the issue. Thanks for taking the time to write it up in addition to the time it must have taken to dive in and figure out what was happening. I certainly don't understand how all the CFG sorting works, so once things are working smoothly end-to-end, I would welcome a chance to understand it more deeply.
While I understand how CFGSort works, I also don't completely understand all the motivations under the algorithms, such as why we have separate `Preferred` and `Ready` lists. I actually asked Dan once and he said he didn't remember 🙃 But I also have been cautious of changing existing algorithms because I'm not sure how it will affect the performance.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97247/new/
https://reviews.llvm.org/D97247
More information about the llvm-commits
mailing list