[PATCH] D97110: [InstrProfiling] Use nobits as __llvm_prf_cnts section type in ELF

Tue Feb 23 14:50:04 PST 2021

Conanap added a comment.

In D97110#2583184 <https://reviews.llvm.org/D97110#2583184>, @phosek wrote:

> In D97110#2583082 <https://reviews.llvm.org/D97110#2583082>, @phosek wrote:
>
>> In D97110#2583026 <https://reviews.llvm.org/D97110#2583026>, @Conanap wrote:
>>
>>> Hello,
>>>
>>> Power PC is also experiencing the same error,
>>>
>>>   Malformed instrumentation profile data
>>>    error: No profiles could be merged.
>>>
>>> I built a branch of `main` with this change reverted and the error goes away. Would it be possible to have this reverted for now until a proper solution has been created? Thanks!
>>
>> I've managed to reproduce this locally in a Docker container. It's a bug in the older binutils bfd ld, the `__start_` and `__stop_` have incorrect addresses, it's working correctly in gold and also in newer binutils versions. I'll send a change to conditionally enable this feature with `-fbinutils-version=`, I'm just trying to identify what version of binutils this was fixed in.
>
> I have bisected this to binutils 2.28 and I have sent D97336 <https://reviews.llvm.org/D97336> to conditionalize the use of `nobits` to binutils >=2.28.

Awesome, thank you for the prompt response! I appreciate it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97110/new/

https://reviews.llvm.org/D97110