[PATCH] D96184: [AIX][TLS] Generate TLS variables in assembly files

[Victor Huang via Phabricator via llvm-commits]

NeHuang added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:2105
+  if (GV->hasCommonLinkage() || GVKind.isBSSLocal() ||
+      (GVKind.isThreadBSS() && GlobalValue::isLocalLinkage(GV->getLinkage()))) {
     Align Alignment = GV->getAlign().getValueOr(DL.getPreferredAlign(GV));
----------------
Update the comments to explain all the scenarios.


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:2112
+    if (GVKind.isBSSLocal() ||
+        (GVKind.isThreadBSS() && GV->hasInternalLinkage()))
       OutStreamer->emitXCOFFLocalCommonSymbol(
----------------
check if "GV->hasInternalLinkage()" and "GVKind.isThreadBSS() && GlobalValue::isLocalLinkage(GV->getLinkage())" are equivalent 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96184/new/

https://reviews.llvm.org/D96184