[PATCH] D96035: [WIP][dsymutil][DWARFlinker] implement separate multi-thread processing for compile units.

Tue Feb 23 12:11:28 PST 2021

avl added a comment.

In D96035#2582811 <https://reviews.llvm.org/D96035#2582811>, @echristo wrote:

> In D96035#2582780 <https://reviews.llvm.org/D96035#2582780>, @avl wrote:
>
>> In D96035#2582232 <https://reviews.llvm.org/D96035#2582232>, @JDevlieghere wrote:
>>
>>> In D96035#2579270 <https://reviews.llvm.org/D96035#2579270>, @dblaikie wrote:
>>>
>>>> A non-deterministic behavior is probably not acceptable - it'd certainly be no good at Google if we ever wanted to use this for DWARF linking. Not sure how the Apple folks feel about it for classic dsymutil.
>>>
>>> Yes, this would be a non-starter.
>>
>> even if it IS deterministic in --num-threads=1, and is Not deterministic in multi-thread case?
>
> Yes :)

I see. I tried to preserve existing idea of ODR uniquing in this patch. To make it in multi-thread way and to have a deterministic behavior  - Could we consider to change current ODR uniquing algorithm?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96035/new/

https://reviews.llvm.org/D96035