[PATCH] D97250: [test-suite] Robust warnings for Fortran Test Suite tests that require Ninja.

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added inline comments.


================
Comment at: CMakeLists.txt:11-16
   if(NOT CMAKE_GENERATOR STREQUAL "Ninja")
       message(WARNING
-	"Fortran test suite may NOT build with this CMAKE_GENERATOR = ${CMAKE_GENERATOR}.\n"
-	"Recommend using Ninja 1.10 or later by adding -G \"Ninja\" to cmake invocation.")
+	"Fortran test suite will NOT build certain tests with this CMAKE_GENERATOR = ${CMAKE_GENERATOR}.\n"
+	"Strongly recommend using Ninja 1.10 or later by adding -G \"Ninja\" to cmake invocation.\n"
+	"More details here: https://gitlab.kitware.com/cmake/cmake/-/issues/16590")
   endif()
----------------
naromero77 wrote:
> Meinersbur wrote:
> > Assuming that we add `ninja_required()` to every test that needs it, this warning is unnecessary. 
> > 
> > If such a test is included in `TEST_SUITE_SUBDRS`: Get warning and error
> > Otherwise: Warning does not apply
> Your suggestion is to just get rid of the warning in the top-level CMakeLists.txt completely, since its redundant with `ninja_required()`? 
> 
> Can you confirm?
Correct


Repository:
  rT test-suite

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97250/new/

https://reviews.llvm.org/D97250