[PATCH] D97247: [WebAssembly] Fix incorrect grouping and sorting of exceptions

[Derek Schuff via Phabricator via llvm-commits]

dschuff accepted this revision.
dschuff added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/FunctionLoweringInfo.cpp:343
     }
     EHInfo.SrcToUnwindDest = std::move(NewMap);
+    NewMap.clear();
----------------
does `move`ing from `NewMap` mean it can't be touched anymore at all? Or is calling some kind of initialization function on it OK?
I guess if we think it's not ok, we could always use `swap` instead.


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyExceptionInfo.cpp:74
+  // (The example is try-catches for illustration purpose, but the unwind
+  // destination catn be also a cleanuppad generated by destructor calls.) So
+  // the unwind destination is in the outside of the catchpad's exception.
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97247/new/

https://reviews.llvm.org/D97247