[PATCH] D97257: collectUsedGlobalVariables: migrate SmallPtrSetImpl overload to SmallVecImpl overload
Teresa Johnson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 23 11:34:40 PST 2021
tejohnson added inline comments.
================
Comment at: llvm/lib/Object/IRSymtab.cpp:125
+ collectUsedGlobalVariables(*M, UsedV, /*CompilerUsed=*/false);
+ for (GlobalValue *V : UsedV)
+ Used.insert(V);
----------------
Can you simply use a different constructor for Used that takes the begin and end iterator to avoid a loop? Here and other places where possible.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97257/new/
https://reviews.llvm.org/D97257
More information about the llvm-commits
mailing list