[PATCH] D97163: [GlobalISel] Implement fewerElements legalization for vector reductions.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 23 11:28:19 PST 2021


arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:4092
+  const unsigned NumParts = SrcTy.getNumElements() / NarrowTy.getNumElements();
+  extractParts(SrcReg, NarrowTy, NumParts, SplitSrcs);
+  SmallVector<Register> PartialReductions;
----------------
I've been trying to move away from using extractParts. Can you reframe this with extractGCDType to handle the odd cases?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97163/new/

https://reviews.llvm.org/D97163



More information about the llvm-commits mailing list