[PATCH] D74927: [MC][ARM] make Thumb function also if type attribute is set

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers updated this revision to Diff 325843.
nickdesaulniers marked 4 inline comments as done.
nickdesaulniers added a comment.

- convert test to llvm-readelf, add test for mixed .thumb/.arm, add ifunc test, use CHECK-NEXT


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74927/new/

https://reviews.llvm.org/D74927

Files:
  llvm/lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp
  llvm/test/MC/ARM/thumb-function-address.s


Index: llvm/test/MC/ARM/thumb-function-address.s
===================================================================
--- /dev/null
+++ llvm/test/MC/ARM/thumb-function-address.s
@@ -0,0 +1,37 @@
+@ RUN: llvm-mc -filetype=obj -triple=armv7-linux-gnueabi %s -o %t
+@ RUN: llvm-readelf -s %t | FileCheck %s
+
+.syntax unified
+.text
+.thumb
+func_label:
+.type func_label, %function
+
+.type foo_impl, %function
+foo_impl:
+  bx lr
+.type foo_resolver, %function
+foo_resolver:
+  b foo_impl
+.type foo, %gnu_indirect_function
+.set foo, foo_resolver
+
+@@ Note: GNU as sets the value to 1.
+.thumb
+label:
+  bx lr
+.arm
+  bx lr
+.type label, %function
+
+@@ Check func_label, foo_impl, foo_resolver, and foo addresses have bit 1 set.
+@@ Check label has bit 1 unset.
+@ CHECK:      Value Size Type Bind Vis Ndx Name
+@ CHECK-NEXT: 00000000 0 NOTYPE LOCAL DEFAULT UND
+@ CHECK-NEXT: 00000001 0 FUNC LOCAL DEFAULT 2 func_label
+@ CHECK-NEXT: 00000001 0 FUNC LOCAL DEFAULT 2 foo_impl
+@ CHECK-NEXT: 00000000 0 NOTYPE LOCAL DEFAULT 2 $t.0
+@ CHECK-NEXT: 00000003 0 FUNC LOCAL DEFAULT 2 foo_resolver
+@ CHECK-NEXT: 00000003 0 IFUNC LOCAL DEFAULT 2 foo
+@ CHECK-NEXT: 00000004 0 FUNC LOCAL DEFAULT 2 label
+@ CHECK-NEXT: 00000006 0 NOTYPE LOCAL DEFAULT 2 $a.1
Index: llvm/lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp
===================================================================
--- llvm/lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp
+++ llvm/lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp
@@ -579,6 +579,28 @@
     }
   }
 
+  /// If a label is defined before the .type directive sets the label's type
+  /// then the label can't be recorded as thumb function when the label is
+  /// defined. We override emitSymbolAttribute() which is called as part of the
+  /// parsing of .type so that if the symbol has already been defined we can
+  /// record the label as Thumb. FIXME: there is a corner case where the state
+  /// is changed in between the label definition and the .type directive, this
+  /// is not expected to occur in practice and handling it would require the
+  /// backend to track IsThumb for every label.
+  bool emitSymbolAttribute(MCSymbol *Symbol, MCSymbolAttr Attribute) override {
+    bool Val = MCELFStreamer::emitSymbolAttribute(Symbol, Attribute);
+
+    if (!IsThumb)
+      return Val;
+
+    unsigned Type = cast<MCSymbolELF>(Symbol)->getType();
+    if ((Type == ELF::STT_FUNC || Type == ELF::STT_GNU_IFUNC) &&
+        Symbol->isDefined())
+      getAssembler().setIsThumbFunc(Symbol);
+
+    return Val;
+  };
+
 private:
   enum ElfMappingSymbol {
     EMS_None,


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74927.325843.patch
Type: text/x-patch
Size: 2601 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210223/b336dcc0/attachment.bin>