[PATCH] D97260: [lld][MachO] Add support for LC_FUNCTION_STARTS

Tue Feb 23 10:51:37 PST 2021

int3 added inline comments.

================
Comment at: lld/test/MachO/function-starts.s:7-9
+# CHECK: 0000000100000282
+# CHECK: 0000000100000280
+# CHECK: 0000000100000281
----------------
we try to avoid hardcoded addresses (as you've noticed in the other tests, updating them is a bit annoying). In this case we could use numeric substitutions to cross-check the values here with addresses from the symbol table

================
Comment at: lld/test/MachO/function-starts.s:17
+  retq
+_f2:
+  retq
----------------
seems worth testing the case where two symbols alias to the same address

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97260/new/

https://reviews.llvm.org/D97260