[PATCH] D97290: [LoopInterchange] Replace tightly-nesting-ness check with the one from `LoopNest`

Whitney Tsang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 23 10:49:54 PST 2021


Whitney added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LoopInterchange.cpp:453
   bool run(LoopNest &LN) {
-    const auto &LoopList = LN.getLoops();
-    for (unsigned I = 1; I < LoopList.size(); ++I)
-      if (LoopList[I]->getParentLoop() != LoopList[I - 1])
-        return false;
-    return processLoopList(LoopList);
+    if (!LN.isTotallyNested())
+      return false;
----------------
As `checkLoopsStructure` is going to check `the inner loop should be the outer loop's only child`, do we really need to check `isTotallyNested` here?



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97290/new/

https://reviews.llvm.org/D97290



More information about the llvm-commits mailing list