[PATCH] D97254: [llvm] Add assertions for the smart pointers with the possibility to be null returned from ThinLTOCodeGenerator::linkCombinedIndex

Steven Wu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 23 09:56:36 PST 2021


steven_wu added a comment.

This one might be better just fix the `FIXME` in linkCombinedIndex since `assert` won't do anything in the release build.

Maybe instead of `logAllUnhandledErrors`, just `report_fatal_error` in `linkCombindedIndex()`? Then we should not get a nullptr from the function.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97254/new/

https://reviews.llvm.org/D97254



More information about the llvm-commits mailing list