[PATCH] D97306: [SimplifyCFG] avoid creating unnecessary assume calls

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 23 09:49:54 PST 2021


lebedev.ri added a comment.

I think the fact that we are *not* creating such assumes in most of the places is a bug.
I can't really comment on the strain such assumes incur on the optimization pipeline,
but i don't expect it to be too high, and i do think that should be fixed (by assume operand bundles?)
rather than the use case be shunned into a corner and avoided.

Concretely, i would expect that this will pessimize e.g. the case where
we are operating on a function argument, we happen to not have other uses,
so we don't emit an assumption, but then we inline the function
and suddenly there are uses that would have benefitted from that knowledge,
but it has been lost by then..


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97306/new/

https://reviews.llvm.org/D97306



More information about the llvm-commits mailing list