[PATCH] D97136: [VPlan] Support to widen select intructions in VPlan native path

[Mauri Mustonen via Phabricator via llvm-commits]

Kazhuu added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp:75
+        } else if (SelectInst *SI = dyn_cast<SelectInst>(Inst)) {
+          bool InvariantCond = PSE.getSE()->isLoopInvariant(
+              PSE.getSCEV(SI->getOperand(0)), OrigLoop);
----------------
fhahn wrote:
> I think we should test all possible for loop invariant conditions (in inner & outer loop).
Can you elaborate a bit what you mean? Like test that is the condition invariant for all inner and outer loops?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97136/new/

https://reviews.llvm.org/D97136