[PATCH] D97197: [flang][driver] Refine tests for module search directories

Tim Keith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 23 09:07:09 PST 2021


tskeith added inline comments.


================
Comment at: flang/test/Flang-Driver/Inputs/module-dir/basictestmoduleone.mod:3
 module basictestmoduleone
-type::t2
-end type
 end
----------------
awarzynski wrote:
> tskeith wrote:
> > Rather than check in the `.mod` files (whose format can change at any time) it would be better to check in the Fortran source and compile it for tests that need it. It would make the tests less fragile.
> I agree that we should aim for something more reliable/stable. Could that be a separate patch though?
Yes, that's fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97197/new/

https://reviews.llvm.org/D97197



More information about the llvm-commits mailing list