[PATCH] D97208: [X86] Always use rip-relative addressing on 64-bit when rematerializing all zeros/ones registers using a folded load.

[Pengfei Wang via Phabricator via llvm-commits]

pengfei added a comment.

In D97208#2581481 <https://reviews.llvm.org/D97208#2581481>, @pengfei wrote:

> In D97208#2581319 <https://reviews.llvm.org/D97208#2581319>, @RKSimon wrote:
>
>> FYI I raised https://bugs.llvm.org/show_bug.cgi?id=45091 about better exposing pointer offsets on x86 as we've missed some regressions in the past from this but nothing has happened on it
>
> It seems the script also handles these cases by
>
>   # Detect stack spills and reloads and hide their exact offset and whether
>   # they used the stack pointer or frame pointer.
>   asm = SCRUB_X86_SPILL_RELOAD_RE.sub(r'{{[-0-9]+}}(%\1{{[sb]}}p)\2', asm)

May be we can add an extra option like

  if getattr(args, 'x86_keep_offset', False):
    asm = SCRUB_X86_SPILL_RELOAD_RE.sub(r'{{[-0-9]+}}(%\1{{[sb]}}p)\2', asm)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97208/new/

https://reviews.llvm.org/D97208