[PATCH] D88386: [MIR][M68K] (Patch 2/8): Changes on Target-independent MIR part

Jessica Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 23 04:53:20 PST 2021


jrtc27 accepted this revision.
jrtc27 added a comment.

Minor whitespace issues to fix otherwise fine by me.



================
Comment at: llvm/include/llvm/CodeGen/MachineBasicBlock.h:855
   }
+  /// Has exact same behavior as @ref findDebugLoc (it also
+  /// searches from the first to the last MI of this MBB) except
----------------
Needs a blank line


================
Comment at: llvm/include/llvm/CodeGen/MachineBasicBlock.h:869
   }
+  /// Has exact same behavior as @ref findPrevDebugLoc (it also
+  /// searches from the last to the first MI of this MBB) except
----------------
Needs a blank line


================
Comment at: llvm/lib/CodeGen/MachineBasicBlock.cpp:1367
 }
+DebugLoc MachineBasicBlock::rfindDebugLoc(reverse_instr_iterator MBBI) {
+  // Skip debug declarations, we don't want a DebugLoc from them.
----------------
Needs a blank line


================
Comment at: llvm/lib/CodeGen/MachineBasicBlock.cpp:1384
 }
+DebugLoc MachineBasicBlock::rfindPrevDebugLoc(reverse_instr_iterator MBBI) {
+  if (MBBI == instr_rend())
----------------
Needs a blank line


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88386/new/

https://reviews.llvm.org/D88386



More information about the llvm-commits mailing list