[PATCH] D96632: [THUMB2] add .w suffixes for ldr/str (immediate) T4

[David Spickett via Phabricator via llvm-commits]

DavidSpickett accepted this revision.
DavidSpickett added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/test/MC/ARM/thumb2-ldr.w-str.w.s:123
+ldr.w r0, [r1], #4
+ldr.w sp, [r1], #4 @ TODO: GAS warns for this
+ldr.w pc, [r1], #4
----------------
nickdesaulniers wrote:
> DavidSpickett wrote:
> > DavidSpickett wrote:
> > > Do you have a plan for how to implement these? I assume it's complicated in the same way the alias constraints are.
> > Should be possible to warn by "return Warning" from ARMAsmParser::validateInstruction but I haven't tried it myself.
> I don't plan to implement those in this commit.  The underlying aliased-to instruction doesn't warn.
> 
> Specifically, the warning GAS produces is `This instruction may be unpredictable if executed on M-profile cores with interrupts enabled.`
> 
> I'm not sure we have such a warning.
Ah I thought it was the usual sp/pc is always unpredictable stuff. Fine to leave it out here then.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96632/new/

https://reviews.llvm.org/D96632