[PATCH] D96292: [llvm-objcopy] Drop S_ISUID and S_ISGID bits

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 22 21:36:44 PST 2021


MaskRay abandoned this revision.
MaskRay added a comment.

I investigated the old and new binutils behaviors a bit. I think we need to do D97253 <https://reviews.llvm.org/D97253>: If input=output, preserve umask bits, otherwise drop S_ISUID/S_ISGID bits

  chmod u+s,g+s,o+x a
  sudo llvm-strip a -o b

is still a case that we want to change to match `cp`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96292/new/

https://reviews.llvm.org/D96292



More information about the llvm-commits mailing list