[PATCH] D96757: [InstrProfiling] Use ELF section groups for counters, data and values

Mon Feb 22 17:52:51 PST 2021

phosek added a comment.

In D96757#2580522 <https://reviews.llvm.org/D96757#2580522>, @MaskRay wrote:

> In D96757#2580519 <https://reviews.llvm.org/D96757#2580519>, @phosek wrote:
>
>> In D96757#2580469 <https://reviews.llvm.org/D96757#2580469>, @aeubanks wrote:
>>
>>> `instrprof-gc-sections.c` is failing for me:
>>
>> Do you have `lld` installed on your host? This looks like as if the test was using an older `lld` and not the one from your build.
>
> `lld-available` may be a bit tricky. I can never tell when `lld-available` or `lld` should be used:( Perhaps disable the test temporarily (would be better for @aeubanks to do that as he can test the configuration)

`lld-available` is set based on `COMPILER_RT_HAS_LLD` (https://github.com/llvm/llvm-project/blob/06e25d56451977ef5b7052282faacfe3d42acb65/compiler-rt/CMakeLists.txt#L595) which may be `TRUE` but `TARGET lld` may still return `FALSE` depending on the order in which projects are processed.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96757/new/

https://reviews.llvm.org/D96757