[PATCH] D96757: [InstrProfiling] Use ELF section groups for counters, data and values

[Petr Hosek via Phabricator via llvm-commits]

phosek added a comment.

In D96757#2580518 <https://reviews.llvm.org/D96757#2580518>, @aeubanks wrote:

> Looks like `lld` isn't getting built when I run `ninja check-profile`. Manually building it then running `check-profile` works.

I think the problem is that depending on the order in which projects are processed, `TARGET lld` on https://github.com/llvm/llvm-project/blob/06e25d56451977ef5b7052282faacfe3d42acb65/compiler-rt/test/profile/CMakeLists.txt#L8 might return `FALSE` in case compiler-rt is processed before lld so this is not sufficient. What's not clear to me is how does this work for other runtimes like ASan which use the same pattern, see https://github.com/llvm/llvm-project/blob/main/compiler-rt/test/asan/CMakeLists.txt#L29 (or maybe it doesn't and nobody noticed).

I'll try to come up with a fix if you're not in a hurry, otherwise I can revert the change and reland it later.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96757/new/

https://reviews.llvm.org/D96757