[PATCH] D96757: [InstrProfiling] Use ELF section groups for counters, data and values

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added a comment.

`instrprof-gc-sections.c` is failing for me:

  FAIL: Profile-x86_64 :: instrprof-gc-sections.c (1 of 1)
  ******************** TEST 'Profile-x86_64 :: instrprof-gc-sections.c' FAILED ********************
  Script:
  --
  : 'RUN: at line 3';      /usr/local/google/home/aeubanks/repos/llvm-project2/build/cmake/./bin/clang   -m64  -ldl  -fprofile-instr-generate=/usr/local/google/home/aeubanks/repos/llvm-project2/build/cmake/projects/compiler-rt/test/profile/Profile-x86_64/Output/instrprof-gc-sections.c.tmp.profraw -fuse-ld=lld -fcoverage-mapping -mllvm -enable-name-compression=false -DCODE=1 -ffunction-sections -fdata-sections -Wl,--gc-sections -o /usr/local/google/home/aeubanks/repos/llvm-project2/build/cmake/projects/compiler-rt/test/profile/Profile-x86_64/Output/instrprof-gc-sections.c.tmp /usr/local/google/home/aeubanks/repos/llvm-project2/compiler-rt/test/profile/instrprof-gc-sections.c
  : 'RUN: at line 4';    /usr/local/google/home/aeubanks/repos/llvm-project2/build/cmake/projects/compiler-rt/test/profile/Profile-x86_64/Output/instrprof-gc-sections.c.tmp
  : 'RUN: at line 5';   llvm-profdata merge -o /usr/local/google/home/aeubanks/repos/llvm-project2/build/cmake/projects/compiler-rt/test/profile/Profile-x86_64/Output/instrprof-gc-sections.c.tmp.profdata /usr/local/google/home/aeubanks/repos/llvm-project2/build/cmake/projects/compiler-rt/test/profile/Profile-x86_64/Output/instrprof-gc-sections.c.tmp.profraw
  : 'RUN: at line 6';   llvm-profdata show --all-functions /usr/local/google/home/aeubanks/repos/llvm-project2/build/cmake/projects/compiler-rt/test/profile/Profile-x86_64/Output/instrprof-gc-sections.c.tmp.profdata | FileCheck /usr/local/google/home/aeubanks/repos/llvm-project2/compiler-rt/test/profile/instrprof-gc-sections.c -check-prefix=PROF
  : 'RUN: at line 7';   llvm-cov show /usr/local/google/home/aeubanks/repos/llvm-project2/build/cmake/projects/compiler-rt/test/profile/Profile-x86_64/Output/instrprof-gc-sections.c.tmp -instr-profile /usr/local/google/home/aeubanks/repos/llvm-project2/build/cmake/projects/compiler-rt/test/profile/Profile-x86_64/Output/instrprof-gc-sections.c.tmp.profdata | FileCheck /usr/local/google/home/aeubanks/repos/llvm-project2/compiler-rt/test/profile/instrprof-gc-sections.c -check-prefix=COV
  : 'RUN: at line 8';   llvm-nm /usr/local/google/home/aeubanks/repos/llvm-project2/build/cmake/projects/compiler-rt/test/profile/Profile-x86_64/Output/instrprof-gc-sections.c.tmp | FileCheck /usr/local/google/home/aeubanks/repos/llvm-project2/compiler-rt/test/profile/instrprof-gc-sections.c -check-prefix=NM
  : 'RUN: at line 9';   llvm-readelf -x __llvm_prf_names /usr/local/google/home/aeubanks/repos/llvm-project2/build/cmake/projects/compiler-rt/test/profile/Profile-x86_64/Output/instrprof-gc-sections.c.tmp | FileCheck /usr/local/google/home/aeubanks/repos/llvm-project2/compiler-rt/test/profile/instrprof-gc-sections.c -check-prefix=PRF_NAMES
  : 'RUN: at line 10';   llvm-size -A /usr/local/google/home/aeubanks/repos/llvm-project2/build/cmake/projects/compiler-rt/test/profile/Profile-x86_64/Output/instrprof-gc-sections.c.tmp | FileCheck /usr/local/google/home/aeubanks/repos/llvm-project2/compiler-rt/test/profile/instrprof-gc-sections.c -check-prefix=PRF_CNTS
  : 'RUN: at line 12';      /usr/local/google/home/aeubanks/repos/llvm-project2/build/cmake/./bin/clang   -m64  -ldl  -fprofile-instr-generate=/usr/local/google/home/aeubanks/repos/llvm-project2/build/cmake/projects/compiler-rt/test/profile/Profile-x86_64/Output/instrprof-gc-sections.c.tmp.lto.profraw -fuse-ld=lld -fcoverage-mapping -mllvm -enable-name-compression=false -DCODE=1 -ffunction-sections -fdata-sections -Wl,--gc-sections -flto -o /usr/local/google/home/aeubanks/repos/llvm-project2/build/cmake/projects/compiler-rt/test/profile/Profile-x86_64/Output/instrprof-gc-sections.c.tmp.lto /usr/local/google/home/aeubanks/repos/llvm-project2/compiler-rt/test/profile/instrprof-gc-sections.c
  : 'RUN: at line 13';    /usr/local/google/home/aeubanks/repos/llvm-project2/build/cmake/projects/compiler-rt/test/profile/Profile-x86_64/Output/instrprof-gc-sections.c.tmp.lto
  : 'RUN: at line 14';   llvm-profdata merge -o /usr/local/google/home/aeubanks/repos/llvm-project2/build/cmake/projects/compiler-rt/test/profile/Profile-x86_64/Output/instrprof-gc-sections.c.tmp.lto.profdata /usr/local/google/home/aeubanks/repos/llvm-project2/build/cmake/projects/compiler-rt/test/profile/Profile-x86_64/Output/instrprof-gc-sections.c.tmp.lto.profraw
  : 'RUN: at line 15';   llvm-profdata show --all-functions /usr/local/google/home/aeubanks/repos/llvm-project2/build/cmake/projects/compiler-rt/test/profile/Profile-x86_64/Output/instrprof-gc-sections.c.tmp.lto.profdata | FileCheck /usr/local/google/home/aeubanks/repos/llvm-project2/compiler-rt/test/profile/instrprof-gc-sections.c -check-prefix=PROF
  : 'RUN: at line 16';   llvm-cov show /usr/local/google/home/aeubanks/repos/llvm-project2/build/cmake/projects/compiler-rt/test/profile/Profile-x86_64/Output/instrprof-gc-sections.c.tmp.lto -instr-profile /usr/local/google/home/aeubanks/repos/llvm-project2/build/cmake/projects/compiler-rt/test/profile/Profile-x86_64/Output/instrprof-gc-sections.c.tmp.lto.profdata | FileCheck /usr/local/google/home/aeubanks/repos/llvm-project2/compiler-rt/test/profile/instrprof-gc-sections.c -check-prefix=COV
  : 'RUN: at line 17';   llvm-nm /usr/local/google/home/aeubanks/repos/llvm-project2/build/cmake/projects/compiler-rt/test/profile/Profile-x86_64/Output/instrprof-gc-sections.c.tmp.lto | FileCheck /usr/local/google/home/aeubanks/repos/llvm-project2/compiler-rt/test/profile/instrprof-gc-sections.c -check-prefix=NM
  : 'RUN: at line 18';   llvm-readelf -x __llvm_prf_names /usr/local/google/home/aeubanks/repos/llvm-project2/build/cmake/projects/compiler-rt/test/profile/Profile-x86_64/Output/instrprof-gc-sections.c.tmp.lto | FileCheck /usr/local/google/home/aeubanks/repos/llvm-project2/compiler-rt/test/profile/instrprof-gc-sections.c -check-prefix=PRF_NAMES
  : 'RUN: at line 19';   llvm-size -A /usr/local/google/home/aeubanks/repos/llvm-project2/build/cmake/projects/compiler-rt/test/profile/Profile-x86_64/Output/instrprof-gc-sections.c.tmp.lto | FileCheck /usr/local/google/home/aeubanks/repos/llvm-project2/compiler-rt/test/profile/instrprof-gc-sections.c -check-prefix=PRF_CNTS
  : 'RUN: at line 30';      /usr/local/google/home/aeubanks/repos/llvm-project2/build/cmake/./bin/clang   -m64  -ldl  -fprofile-generate=/usr/local/google/home/aeubanks/repos/llvm-project2/build/cmake/projects/compiler-rt/test/profile/Profile-x86_64/Output/instrprof-gc-sections.c.tmp.pgo.profraw -fuse-ld=lld -DCODE=1 -ffunction-sections -fdata-sections -Wl,--gc-sections -o /usr/local/google/home/aeubanks/repos/llvm-project2/build/cmake/projects/compiler-rt/test/profile/Profile-x86_64/Output/instrprof-gc-sections.c.tmp.pgo /usr/local/google/home/aeubanks/repos/llvm-project2/compiler-rt/test/profile/instrprof-gc-sections.c
  : 'RUN: at line 31';    /usr/local/google/home/aeubanks/repos/llvm-project2/build/cmake/projects/compiler-rt/test/profile/Profile-x86_64/Output/instrprof-gc-sections.c.tmp.pgo
  : 'RUN: at line 32';   llvm-profdata merge -o /usr/local/google/home/aeubanks/repos/llvm-project2/build/cmake/projects/compiler-rt/test/profile/Profile-x86_64/Output/instrprof-gc-sections.c.tmp.pgo.profdata /usr/local/google/home/aeubanks/repos/llvm-project2/build/cmake/projects/compiler-rt/test/profile/Profile-x86_64/Output/instrprof-gc-sections.c.tmp.pgo.profraw
  : 'RUN: at line 33';   llvm-profdata show --all-functions /usr/local/google/home/aeubanks/repos/llvm-project2/build/cmake/projects/compiler-rt/test/profile/Profile-x86_64/Output/instrprof-gc-sections.c.tmp.pgo.profdata | FileCheck /usr/local/google/home/aeubanks/repos/llvm-project2/compiler-rt/test/profile/instrprof-gc-sections.c -check-prefix=PGO
  : 'RUN: at line 34';   llvm-nm /usr/local/google/home/aeubanks/repos/llvm-project2/build/cmake/projects/compiler-rt/test/profile/Profile-x86_64/Output/instrprof-gc-sections.c.tmp.pgo | FileCheck /usr/local/google/home/aeubanks/repos/llvm-project2/compiler-rt/test/profile/instrprof-gc-sections.c -check-prefix=NM
  --
  Exit Code: 1
  
  Command Output (stderr):
  --
  + : 'RUN: at line 3'
  + /usr/local/google/home/aeubanks/repos/llvm-project2/build/cmake/./bin/clang -m64 -ldl -fprofile-instr-generate=/usr/local/google/home/aeubanks/repos/llvm-project2/build/cmake/projects/compiler-rt/test/profile/Profile-x86_64/Output/instrprof-gc-sections.c.tmp.profraw -fuse-ld=lld -fcoverage-mapping -mllvm -enable-name-compression=false -DCODE=1 -ffunction-sections -fdata-sections -Wl,--gc-sections -o /usr/local/google/home/aeubanks/repos/llvm-project2/build/cmake/projects/compiler-rt/test/profile/Profile-x86_64/Output/instrprof-gc-sections.c.tmp /usr/local/google/home/aeubanks/repos/llvm-project2/compiler-rt/test/profile/instrprof-gc-sections.c
  + : 'RUN: at line 4'
  + /usr/local/google/home/aeubanks/repos/llvm-project2/build/cmake/projects/compiler-rt/test/profile/Profile-x86_64/Output/instrprof-gc-sections.c.tmp
  + : 'RUN: at line 5'
  + llvm-profdata merge -o /usr/local/google/home/aeubanks/repos/llvm-project2/build/cmake/projects/compiler-rt/test/profile/Profile-x86_64/Output/instrprof-gc-sections.c.tmp.profdata /usr/local/google/home/aeubanks/repos/llvm-project2/build/cmake/projects/compiler-rt/test/profile/Profile-x86_64/Output/instrprof-gc-sections.c.tmp.profraw
  + : 'RUN: at line 6'
  + llvm-profdata show --all-functions /usr/local/google/home/aeubanks/repos/llvm-project2/build/cmake/projects/compiler-rt/test/profile/Profile-x86_64/Output/instrprof-gc-sections.c.tmp.profdata
  + FileCheck /usr/local/google/home/aeubanks/repos/llvm-project2/compiler-rt/test/profile/instrprof-gc-sections.c -check-prefix=PROF
  /usr/local/google/home/aeubanks/repos/llvm-project2/compiler-rt/test/profile/instrprof-gc-sections.c:53:15: error: PROF-NEXT: is not on the line after the previous match
  // PROF-NEXT: Instrumentation level: Front-end
                ^
  <stdin>:10:1: note: 'next' match was here
  Instrumentation level: Front-end
  ^
  <stdin>:5:19: note: previous match ended here
   Function count: 1
                    ^
  <stdin>:6:1: note: non-matching line after previous match is here
   foo:
  ^
  
  Input file: <stdin>
  Check file: /usr/local/google/home/aeubanks/repos/llvm-project2/compiler-rt/test/profile/instrprof-gc-sections.c
  
  -dump-input=help explains the following input dump.
  
  Input was:
  <<<<<<
           1: Counters:
           2:  main:
           3:  Hash: 0x0000000000000018
           4:  Counters: 1
           5:  Function count: 1
           6:  foo:
           7:  Hash: 0x0000000000000000
           8:  Counters: 1
           9:  Function count: 0
          10: Instrumentation level: Front-end
  next:53     !~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ error: match on wrong line
          11: Functions shown: 2
          12: Total functions: 2
          13: Maximum function count: 1
          14: Maximum internal block count: 0
  >>>>>>
  
  --
  
  ********************
  ********************
  Failed Tests (1):
    Profile-x86_64 :: instrprof-gc-sections.c
  
  
  Testing Time: 0.12s
    Failed: 1

cmake invocation:

  cmake -G Ninja -DLLVM_LOCAL_RPATH=/usr/local/google/home/aeubanks/repos/chromium/src/third_party/llvm-build-tools/gcc-10.2.0-trusty/lib64 '-DCOMPILER_RT_TEST_COMPILER_CFLAGS=--gcc-toolchain=/usr/local/google/home/aeubanks/repos/chromium/src/third_party/llvm-build-tools/gcc-10.2.0-trusty -Wl,-rpath,/usr/local/google/home/aeubanks/repos/chromium/src/third_party/llvm-build-tools/gcc-10.2.0-trusty/lib64 -Wl,-rpath,/usr/local/google/home/aeubanks/repos/chromium/src/third_party/llvm-build-tools/gcc-10.2.0-trusty/lib32' -DLLVM_ENABLE_LIBXML2=FORCE_ON -DLLVM_TARGETS_TO_BUILD=X86 '-DLLVM_ENABLE_PROJECTS=clang;lld;compiler-rt' -DCMAKE_C_FLAGS= -DCMAKE_CXX_FLAGS= -DCMAKE_EXE_LINKER_FLAGS= -DCMAKE_SHARED_LINKER_FLAGS= -DCMAKE_MODULE_LINKER_FLAGS= -DLLVM_ENABLE_ASSERTIONS=ON -DCMAKE_C_COMPILER=/usr/local/google/home/aeubanks/repos/chromium/src/third_party/llvm-build-tools/gcc-10.2.0-trusty/bin/gcc -DCMAKE_CXX_COMPILER=/usr/local/google/home/aeubanks/repos/chromium/src/third_party/llvm-build-tools/gcc-10.2.0-trusty/bin/g++  ../../llvm


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96757/new/

https://reviews.llvm.org/D96757