[PATCH] D97159: [AVR] Fix def state of operands

Mon Feb 22 16:55:14 PST 2021

aykevl added a comment.

Thank you for the review!

================
Comment at: llvm/lib/Target/AVR/AVRRelaxMemOperations.cpp:116
     buildMI(MBB, MBBI, AVR::POPWRd)
-      .addReg(Ptr.getReg(), getKillRegState(Ptr.isKill()));
+      .addDef(Ptr.getReg(), getKillRegState(Ptr.isKill()));

----------------
benshi001 wrote:
> Fix this lint warning.
I intentionally kept it as-is, to match the existing code. See the [golden rule](https://llvm.org/docs/CodingStandards.html#introduction):

> If you are extending, enhancing, or bug fixing already implemented code, use the style that is already being used so that the source is uniform and easy to follow.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97159/new/

https://reviews.llvm.org/D97159