[PATCH] D96351: [AIX] Enable the default AltiVec ABI on AIX

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:15165-15166
+    if (R.first >= (PPC::V0 + 20) && R.second == &PPC::VSRCRegClass)
+      errs() << "warning: vector registers 20 to 32 are reserved in the "
+                "default AIX AltiVec ABI and cannot be used\n";
+  }
----------------
Is there a lot of precedent for "raw output" to stderr for warnings from the back-end? Can we diagnose this closer to where `err_asm_unknown_register_name` is handled in the front-end?


================
Comment at: llvm/lib/Target/PowerPC/PPCRegisterInfo.cpp:348
+    // reserved and cannot be used.
+    for (unsigned I = 0;
+         const unsigned E = array_lengthof(CSR_Altivec_SaveList); ++I) {
----------------
ZarkoCA wrote:
> sfertile wrote:
> > Use a range based for loop.
> Thanks for catching this oversight by me. 
I'm not seeing a range-based for loop here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96351/new/

https://reviews.llvm.org/D96351