[PATCH] D96613: [lld] Add options to trace all symbols and to trace all symbols originated from a file

Mon Feb 22 14:24:15 PST 2021

hoy added a comment.

In D96613#2579911 <https://reviews.llvm.org/D96613#2579911>, @MaskRay wrote:

> In D96613#2579750 <https://reviews.llvm.org/D96613#2579750>, @hoy wrote:
>
>> @MaskRay I'm wondering if you've got any update from the binutils side. Thanks.
>
> I even pinged that for you: https://sourceware.org/pipermail/binutils/2021-February/115455.html
> If you want to reply, you can download https://sourceware.org/pipermail/binutils/2021-February.txt.gz , extract the Message-ID as your In-Reply-To: header.

Thanks for pinging for me!

================
Comment at: lld/ELF/Symbols.h:535
+bool Symbol::needToTraceSymbol() {
+  return traced || config->traceAllSymbols ||
+         (this->file != nullptr &&
----------------
MaskRay wrote:
> MaskRay wrote:
> > Can you measure how much slowdown this will cause?
> And ping on this question: the condition is pretty complex. Does it affect symbol resolution time?
Sorry, I misunderstood your question. I haven't seen noticeable link time difference w/ and w/o this function when no tracing switches is turned on.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96613/new/

https://reviews.llvm.org/D96613