[PATCH] D96109: Refactor implementation of -funique-internal-linkage-names.

[Sriraman Tallam via Phabricator via llvm-commits]

tmsriram added inline comments.


================
Comment at: clang/test/CodeGen/unique-internal-linkage-names-dwarf.c:1
+// This test checks if C functions with internal linkage names are mangled
+// and the module hash suffixes attached including emitting DW_AT_linkage_name.
----------------
MaskRay wrote:
> The test can be converted to IR test (`-emit-llvm`) for better separation of concerns.
> 
> Then llvm-nm & llvm-dwarfdump can be removed here.
I tried that but DW_AT_linkage_name is not emitted in the IR directly.  This needs to be directly checked, I can check in assembly alternately. WDYT?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96109/new/

https://reviews.llvm.org/D96109