[PATCH] D96803: EntryExitInstrumenter: Enable at all optimization levels (PR49143)

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added a comment.

code looks good, just some test nits



================
Comment at: llvm/test/Transforms/EntryExitInstrumenter/mcount.ll:1
-; RUN: opt -passes="function(ee-instrument),cgscc(inline),function(post-inline-ee-instrument)" -S < %s | FileCheck %s
+; RUN: opt --O0 --ee-instrument --inline --post-inline-ee-instrument -S < %s | FileCheck %s
+
----------------
I don't think it makes sense to add tests to `llvm/test`, there should be a clang test for this since the pass is added in clang. These tests aren't really testing the changed code.
Are there any existing tests for `CodeGenOpts.InstrumentFunctions`? We just need to make sure that the calls to the instrument functions exist for `clang -O0`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96803/new/

https://reviews.llvm.org/D96803