[PATCH] D97193: [AArch64][SVE] Ensure hasFP has a consistent return value

Bradley Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 22 07:15:12 PST 2021


bsmith created this revision.
bsmith added reviewers: peterwaller-arm, joechrisellis, sdesmalen.
Herald added subscribers: psnobl, hiraditya, kristof.beyls, tschuett.
Herald added a reviewer: efriedma.
bsmith requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Do the necessary FP profitability checks once, in a new pre CSR spilling
function, referring to that in hasFP. Also ensure that hasFP returns true
prior to this calculation.

This fixes various codegen issues caused by an inconsistent return value
of hasFP, such as PR49217.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D97193

Files:
  llvm/include/llvm/CodeGen/TargetFrameLowering.h
  llvm/lib/CodeGen/PrologEpilogInserter.cpp
  llvm/lib/Target/AArch64/AArch64FrameLowering.cpp
  llvm/lib/Target/AArch64/AArch64FrameLowering.h
  llvm/lib/Target/AArch64/AArch64MachineFunctionInfo.h
  llvm/test/CodeGen/AArch64/debug-info-sve-dbg-value.mir
  llvm/test/CodeGen/AArch64/framelayout-sve.ll
  llvm/test/CodeGen/AArch64/framelayout-sve.mir
  llvm/test/CodeGen/AArch64/sve-calling-convention-mixed.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D97193.325439.patch
Type: text/x-patch
Size: 23072 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210222/1c862720/attachment.bin>


More information about the llvm-commits mailing list