[PATCH] D96632: [THUMB2] add .w suffixes for ldr/str (immediate) T4

David Spickett via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 22 04:36:45 PST 2021


DavidSpickett added inline comments.


================
Comment at: llvm/test/MC/ARM/thumb2-ldr.w-str.w.s:123
+ldr.w r0, [r1], #4
+ldr.w sp, [r1], #4 @ TODO: GAS warns for this
+ldr.w pc, [r1], #4
----------------
DavidSpickett wrote:
> Do you have a plan for how to implement these? I assume it's complicated in the same way the alias constraints are.
Should be possible to warn by "return Warning" from ARMAsmParser::validateInstruction but I haven't tried it myself.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96632/new/

https://reviews.llvm.org/D96632



More information about the llvm-commits mailing list