[PATCH] D97113: ReleaseNotes: add lld/ELF notes

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 22 01:55:44 PST 2021


jhenderson added a comment.

There are a number of common grammar tweaks, I think would make sense. Based on a brief look at other release notes, I think I would phrase things as "XXX is/are **now** supported/retrained/..." rather than simply "is supported", as it emphasises what has changed. Similarly "XXX **now** has support for ..." and "XXX can **now** have/use/...". For "is fixed/added/improved" I'd say "has been fixed/...".



================
Comment at: lld/docs/ReleaseNotes.rst:48
+  (`D84001 <https://reviews.llvm.org/D84001>`_)
+* ``--wrap`` support is improved.
+* ``--gdb-index`` works with DWARF v5 and ``--icf={safe,all}``.
----------------
Links to one or more reviews? What has been improved about the support?


================
Comment at: lld/docs/ReleaseNotes.rst:62
+  (`D91187 <https://reviews.llvm.org/D91187>`_)
+* Some symbol versioning improvements.
+* A COMMON symbol can now cause the fetch of an archive providing a ``STB_GLOBAL`` definition.
----------------
Links to one or more reviews? As it is, this release note is rather useless, I think.


================
Comment at: lld/docs/ReleaseNotes.rst:65
+  This behavior follows GNU ld newer than 1999.
+  If you see ``duplicate symbol`` errors with the new behavior, check out `PR49226 <https://bugs.llvm.org//show_bug.cgi?id=49226>`_.
+  (`D86142 <https://reviews.llvm.org/D86142>`_)
----------------
This suggests this item could be a breaking change? Should it be in that section instead?


================
Comment at: lld/docs/ReleaseNotes.rst:70
+* AArch64 has support for ``R_AARCH64_LD64_GOTPAGE_LO15``.
+* PowerPC64 port detects missing R_PPC64_TLSGD/R_PPC64_TLSLD and disable TLS relaxation.
+  This allows linking with object files produced by very old IBM XL compilers.
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97113/new/

https://reviews.llvm.org/D97113



More information about the llvm-commits mailing list